Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Gradle 8.4 and Error Prone 2.23.0 #849

Merged
merged 5 commits into from
Oct 20, 2023
Merged

Update to Gradle 8.4 and Error Prone 2.23.0 #849

merged 5 commits into from
Oct 20, 2023

Conversation

msridhar
Copy link
Collaborator

@msridhar msridhar commented Oct 18, 2023 •
edited
Loading

Just to stay up to date. Fixed a couple new Error Prone warnings. Also switch to GA JDK 21 in our CI config.

@msridhar msridhar requested a review from lazaroclapp October 18, 2023 20:59
@msridhar msridhar enabled auto-merge (squash) October 18, 2023 20:59
@msridhar msridhar disabled auto-merge October 18, 2023 21:00
@msridhar msridhar marked this pull request as draft October 18, 2023 21:00
@msridhar msridhar changed the title Update to Gradle 8.4 Update to Gradle 8.4 and Error Prone 2.23.0 Oct 18, 2023
@codecov
Copy link

codecov bot commented Oct 18, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8f270e2) 86.87% compared to head (7ddc0f7) 86.87%.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master     #849   +/-   ##
=========================================
  Coverage     86.87%   86.87%           
  Complexity     1880     1880           
=========================================
  Files            74       74           
  Lines          6200     6200           
  Branches       1202     1202           
=========================================
  Hits           5386     5386           
  Misses          406      406           
  Partials        408      408
Files Coverage Δ
.../com/uber/nullaway/jarinfer/BytecodeAnnotator.java 83.60% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msridhar msridhar marked this pull request as ready for review October 18, 2023 22:59
lazaroclapp
lazaroclapp approved these changes Oct 20, 2023
View reviewed changes
Copy link
Collaborator

@lazaroclapp lazaroclapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dep upgrade, LGTM

@msridhar msridhar enabled auto-merge (squash) October 20, 2023 20:45
@msridhar msridhar merged commit f17c91c into uber:master Oct 20, 2023
9 checks passed
@msridhar msridhar deleted the gradle-8.4 branch October 20, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lazaroclapp lazaroclapp lazaroclapp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msridhar @lazaroclapp